search

equalizedigital / accessibility-checker

GNU General Public License v2.0
15 stars 8 forks source link

Empty link rule check misses empty links #697

Closed SteveJonesDev closed 5 days ago

SteveJonesDev commented 6 days ago

The empty_link check misses empty links. Issue reproduced using this test code <a href="https://example.com"></a>.

@pattonwebz is this bug caught when running the end-to-end test in Cypress?

Let's do a patch release on this given its impact.

Ticket: https://wordpress.org/support/topic/cannot-get-empty-link-error-to-trigger/

oldrup commented 5 days ago

Looking forward to testing the patch. @SteveJonesDev, what's the preferred channel to get in touch if experiencing potential issues with the free plugin, here on GitHub or the WordPress forums?

SteveJonesDev commented 5 days ago

@oldrup either channel is fine.

pattonwebz commented 5 days ago

I have a PR up #699 that should fix this and adds some tests to verify that it is working as expected.

@oldrup thanks for reporting this, let me know if you want me to send you a test build to verify this is resolved for you before I release this to the plugin repo.