equalizedigital / accessibility-checker

GNU General Public License v2.0
14 stars 8 forks source link

Style more elements to try prevent leaking from theme into modal #789

Closed pattonwebz closed 1 month ago

pattonwebz commented 1 month ago

When testing the fixes release with TwentyTwenty, theme style leaking into the modal was noticed. This caused style and layout shifting when styles were disabled and enabled. The theme styles should be overridden in the modal and highlight panel.

This PR adds more style rule overrides to combat the style leaking.

Video of the styles being toggled on and off after this change showing no visual differences (except scrollbar changes caused by the underlying content) https://github.com/user-attachments/assets/945f1046-cfdb-42be-9f95-530b394cf683

Basecamp card: https://3.basecamp.com/3579237/buckets/29333825/card_tables/cards/7923057011

Checklist