equalizedigital / student-loan-planner-theme

0 stars 0 forks source link

[Marker.io] add CC #1230

Closed christophermhinds closed 6 months ago

christophermhinds commented 6 months ago

Screenshot_2024-04-29_19-52-22.png

can we add a close caption option to video?


Reported by: Jeffrey Trull (impactfullymedia@gmail.com) - Contact via Marker.io

Source URL: https://slpwealthdev.wpenginepowered.com/

Issue details: Open in Marker.io

Device typedesktop
BrowserChrome 123.0.0.0
Screen Size3440 x 1440
OSOS X 14.4.1
Viewport Size1901 x 991
Pixel Ratio@​1x
creativityincluded commented 6 months ago

Is editing video controls dev or content (or client?)

SteveJonesDev commented 6 months ago

We can add support for WebVTT files to the video carousel block but the client would need to generate and upload those files. I don't think it's with in-scope for use to create the CC files, correct @amberhinds? Let me know if I should proceed.

creativityincluded commented 6 months ago

@SteveJonesDev It looks like from the "Answer this question:" section of this comment that @amberhinds was requesting support for adding captions to the homepage carousel videos: https://3.basecamp.com/3579237/buckets/34517835/card_tables/cards/7213977560#__recording_7306579861

So it seems like they'll have captions on launch so the video player will need the CC display toggle on the player.

We can def. wait for Amber to confirm, that's just how I interpreted these remarks.

amberhinds commented 6 months ago

Captions are added.