Inclusion of CMAKE_CXX_FLAGS in "About" dialog prevents build from being reproducible

equalsraf / neovim-qt

Neovim client library and GUI, in Qt5.

https://github.com/equalsraf/neovim-qt/wiki

ISC License

1.86k stars 171 forks source link

Inclusion of CMAKE_CXX_FLAGS in "About" dialog prevents build from being reproducible #1111

Closed jamessan closed 3 months ago

jamessan commented 5 months ago

https://github.com/equalsraf/neovim-qt/blob/442abfba5399303cda8d8c6e9eaf7ed4227f4820/src/gui/app.cpp#L449

Since CMAKE_CXX_FLAGS can contain things like references to the build path, this prevents the builds of neovim-qt from being full reproducible. This can be seen in the results of the Reproducible Builds project's test for neovim-qt.

Would removing this from the about dialog be acceptable?

equalsraf commented 3 months ago

Sounds good, at the very least I can make it conditional on an a build option.

equalsraf commented 3 months ago

Merged, on by default.