equalsraf / vim-qt

An experimental Qt gui for Vim.
129 stars 14 forks source link

Upstream 8.0.1097 #11

Closed BlackIkeEagle closed 6 years ago

BlackIkeEagle commented 7 years ago

the newest :terminal command is also not working now. I'm kind of out-of-my-league in this.

Can we do a request for people to contribute to vim-qt to help getting the :terminal command working and getting the channels setup correctly?

equalsraf commented 7 years ago

We seem to be missing event handling in the main loop for

I dont have a working patch right now but the core of it seems to be

  1. channel.c in FEAT_GUI_QT needs to be added, likely using a QSocketNotifier
  2. in gui_qt.cpp in gu_mch_wait_for_char (or in our case qvimshell/vimwrapper.cpp), similar to gui_gtk_x11.c for FEAT_JOB_CHANNEL
equalsraf commented 7 years ago

I'm still missing FEAT_TIMERS but https://github.com/equalsraf/vim-qt/pull/12 seems to help with :term

Also I'm not sure if QSocketNotifier works for this in windows, but I also dont know what is the status of :terminal in windows.

BlackIkeEagle commented 7 years ago

nice, thanks @equalsraf