search

equinix-labs / ansible-collection-equinix

Ansible content to help automate the management of Equinix resources
https://deploy.equinix.com/labs/ansible-collection-equinix/
GNU General Public License v3.0
2 stars 8 forks source link

Add modules metal_project_ssh_key{_info}, docs and tests #107

Closed AlexBacho closed 10 months ago

AlexBacho commented 11 months ago

implements https://github.com/equinix-labs/ansible-collection-equinix/issues/65

t0mk commented 11 months ago

@AlexBacho :+1: thanks for the PR, I'll take a look and run the tests.

t0mk commented 11 months ago

I'm not sure how to run the integration tests here in the PR. This https://github.com/equinix-labs/ansible-collection-equinix/blob/main/.github/workflows/integration-tests.yml ..should trigger but didn't, probably because Alex doesn't have a role in the repo. I think we should have a command to run the tests or PR by external people.

What do you think @displague ?

t0mk commented 11 months ago

Looks good but let's merge #108 first