Fix GH actions for build and tests and remove unnecessary workflows

equinix-labs / ansible-collection-equinix

Ansible content to help automate the management of Equinix resources

https://deploy.equinix.com/labs/ansible-collection-equinix/

GNU General Public License v3.0

2 stars 9 forks source link

Fix GH actions for build and tests and remove unnecessary workflows #5

Closed t0mk closed 1 year ago

t0mk commented 1 year ago

This PR fixes legacy github action workflows - build and tests. I don't expect the workflows will work, but I hope they will fail less.

ctreatma commented 1 year ago

Two things:

Can you clarify why the build and units workflows are deleted, but the others are updated? Is the logic from those workflows covered by the ones that are left behind?
I think I'd lean towards one of (1) removing all of the workflows since they don't exist or (2) updating any existing, still-relevant workflows to pass as part of this PR. If we still expect the workflows to fail, I don't think we're getting a benefit out of changing them.

t0mk commented 1 year ago

@ctreatma

I basically tried to tidy up, so that the CI of this repo doesn't send 5 unnecessary emails on each PR commit. This repo is not in shape for CI, the main dependency is not even released yet.

why the build and units workflows are deleted, but the others are updated I wanted to keep the stubs, as a reminder of what to work on first. I think unit tests are the least necessary and the build workflow (release to Ansible galaxy) is the last thing to do.

Would you prefer if I remove all of them? There is no point fixing the CI workflow right now.

t0mk commented 1 year ago

@ctreatma Actually, let's forget about this. I will remove all of the legacy workflows and will start with a new one for integration tests in #8.