equinix-labs / metal-go

[Deprecated] Golang client for Equinix Metal
https://deploy.equinix.com/labs/equinix-sdk-go/
MIT License
3 stars 2 forks source link

[WIP] Share organization_id path definitions between methods #158

Closed displague closed 5 months ago

displague commented 1 year ago

DRAFT Explores what would happen to generated code if paths/ shared a common definition for organization_id instead of having each method (get,patch,post,delete,put) redefine the field.

github-actions[bot] commented 1 year ago

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[WIP] Share organization_id path definitions between methods". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit
displague commented 1 year ago

In another project where the API spec is a single flat file, unifying the various HTTP method parameters to the common path parameter block resulted in a model_foo_collection.go file.

I expected to find that with this change too, where a new type defining the common OrganizationID field would be created in model_foo_collection.go files. This didn't happen.