search

equinix-labs / terraform-equinix-kubernetes-cluster

Kubernetes cluster deployment on Equinix Metal
https://registry.terraform.io/modules/equinix-labs/kubernetes-cluster/equinix/latest
Apache License 2.0
1 stars 5 forks source link

Cloud Provider should not default to External #34

Closed displague closed 11 months ago

displague commented 11 months ago

With the current settings, --cloud-provider=external is set by default. Node taints will be present with this setting and the cluster will not be ready to run various workloads.

There should be a variable that determines if this setting is applied in the templates/userdata or not (likely using terraform template conditions). The documentation for the variable should state what will happen one way or the other.

https://github.com/search?q=repo%3Aequinix-labs%2Fterraform-equinix-kubernetes-cluster%20external&type=code

Today, users must install CPEM, which will clear the taint. This is demonstrated in the example: https://github.com/equinix-labs/terraform-equinix-kubernetes-cluster/blob/main/examples/cpem-add-on/main.tf

When adding this variable, the example should also toggle the new variable. This will result in the module including --cloud-provider=external. CPEM can not be installed if this setting is not present.

displague commented 11 months ago

Using a lightweight, unopinionated, toggle will allow this provider to be used in example projects where CPEM is not desired or where alternative L2 friendly cloud-providers are preferred (such as kube-vip-cloud-provider).