Closed e-minguez closed 1 year ago
@ctreatma thanks for your inputs. I've sorted everything out. PTAL /cc @dcallao
@e-minguez I created a PR against your branch with some of the changes being suggested (or that I would have suggested):
https://github.com/e-minguez/terraform-metal-k3s/pull/1
I ran:
cd examples/demo-cluster
eval $(metal env -o terraform)
export TF_VAR_metal_auth_token
export TF_VAR_metal_project_id
terraform init -upgrade
terraform apply
The Hello World example worked out of the box.
@e-minguez Thanks for submitting these changes. I have tested this last week and will test again today one more time. Will update @displague for final approval then merge. 👍
@e-minguez Thanks for submitting these changes. I have tested this last week and will test again today one more time. Will update @displague for final approval then merge. 👍
Do you want me to update my PR with @displague suggestions? or maybe we can merge this one and @displague can create a follow up PR on this repo? Open to suggestions 😄
@e-minguez Thanks for submitting these changes. I have tested this last week and will test again today one more time. Will update @displague for final approval then merge. 👍
Do you want me to update my PR with @displague suggestions? or maybe we can merge this one and @displague can create a follow up PR on this repo? Open to suggestions 😄
Yes. Please do and thank you again. 👍
@e-minguez I've used some GitHub shenanigans to merge into your branch. Merging this once I get tests passing again (I've offended the linters).
This PR is included in version 0.1.0 :tada:
Complete revamp of the module for 2023
Closes #14 #42
Fixes:
Improvements: