equinix-labs / terraform-equinix-metal-k3s

Manage K3s (k3s.io) region clusters on Equinix Metal
https://registry.terraform.io/modules/equinix/k3s/metal/latest?tab=readme
Apache License 2.0
46 stars 15 forks source link

Complete revamp of the module for 2023 #50

Closed e-minguez closed 1 year ago

e-minguez commented 1 year ago

Complete revamp of the module for 2023

Closes #14 #42

Fixes:

Improvements:

e-minguez commented 1 year ago

@ctreatma thanks for your inputs. I've sorted everything out. PTAL /cc @dcallao

displague commented 1 year ago

@e-minguez I created a PR against your branch with some of the changes being suggested (or that I would have suggested):

https://github.com/e-minguez/terraform-metal-k3s/pull/1

I ran:

cd examples/demo-cluster
eval $(metal env -o terraform)
export TF_VAR_metal_auth_token
export TF_VAR_metal_project_id
terraform init -upgrade
terraform apply

The Hello World example worked out of the box.

dcallao commented 1 year ago

@e-minguez Thanks for submitting these changes. I have tested this last week and will test again today one more time. Will update @displague for final approval then merge. 👍

e-minguez commented 1 year ago

@e-minguez Thanks for submitting these changes. I have tested this last week and will test again today one more time. Will update @displague for final approval then merge. 👍

Do you want me to update my PR with @displague suggestions? or maybe we can merge this one and @displague can create a follow up PR on this repo? Open to suggestions 😄

dcallao commented 1 year ago

@e-minguez Thanks for submitting these changes. I have tested this last week and will test again today one more time. Will update @displague for final approval then merge. 👍

Do you want me to update my PR with @displague suggestions? or maybe we can merge this one and @displague can create a follow up PR on this repo? Open to suggestions 😄

Yes. Please do and thank you again. 👍

displague commented 1 year ago

@e-minguez I've used some GitHub shenanigans to merge into your branch. Merging this once I get tests passing again (I've offended the linters).

github-actions[bot] commented 1 year ago

This PR is included in version 0.1.0 :tada: