equinix / ansible-collection-equinix

Ansible content to help automate the management of Equinix resources
https://deploy.equinix.com/labs/ansible-collection-equinix/
GNU General Public License v3.0
1 stars 1 forks source link

Adopt a code linter and/or formatter #227

Closed ctreatma closed 3 weeks ago

ctreatma commented 2 months ago
SUMMARY

There is a lint task defined in the Makefile that uses pylint and mypy, but that task is never run in any CI jobs and it isn't mentioned in any documentation. The task also does not seem to work as written (pylint reports linting issues, but the subsequent mypy commands are not executed).

We should have a working task for linting and/or formatting of the code so that we notice when code in this repo doesn't align with standards and so that it is easy for contributors to address. We've previously discussed using the black Python formatter to automatically format code here in equinix-sdk-python, and that tool could also be used here.

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION