search

equinix / equinix-sdk-go

Golang client for Equinix APIs
https://deploy.equinix.com/labs/equinix-sdk-go
MIT License
2 stars 4 forks source link

chore: avoid apparent race condition in Make task execution #23

Closed ctreatma closed 5 months ago

ctreatma commented 5 months ago

This is a weird one...somehow, switching to running Go commands in a container (#14), combined with the passage of time (worked fine for me last week, consistently doesn't this week) has broken the make generate-all task (and the underlying make -f Makefile.metalv1 generate task). But only when I'm running locally.

In CI, make generate-all runs just fine (as it used to do for me locally). Today, locally, it fails every time. After digging through loads of console output I found this message about halfway through:

docker  run --rm -u 502:20 -v /Users/ctreatman/Documents/code/equinix-sdk-go:/workdir -w /workdir -e GOCACHE=/tmp/.cache golang:1.19 go mod tidy
go: warning: "all" matched no packages

As a result of this failed execution, the go.mod and go.sum don't declare any dependencies, which eventually causes the Go tests to fail.

github-actions[bot] commented 5 months ago

This PR is included in version 0.31.2 :tada: