Closed thogarty closed 3 months ago
@thogarty Please share the final testing report (screenshot or logs) generated with this code.
@d-bhola, we decided not to do screenshots (not easily viewable) and just have the reviewer look at the latest action runs for the PR.
You can view them here: https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-fcr-prod-suite.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-port-prod-suite.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-metal-nimf-suite.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-virtualdevice-prod-suite.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-prod-suite-all.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-uat-suite.yaml
@d-bhola, we decided not to do screenshots (not easily viewable) and just have the reviewer look at the latest action runs for the PR.
You can view them here: https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-fcr-prod-suite.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-port-prod-suite.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-metal-nimf-suite.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-virtualdevice-prod-suite.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-prod-suite-all.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-uat-suite.yaml 👍
@srushti-patl , we aren't exposing those examples publicly. They're just for internal testing and don't require the additional context. We only need README.md's and .tfvars.example for published example modules
Is there a way to remove/modify the question marks for better presentation of the test report?
@d-bhola , beyond the scope of this task. We're using third party tools for the heavy lifting and that would require a second fork (we're already using a fork of go-junit-report). If we had more control over the source code I'd be happy to oblige but it's too much effort for too little reward.
@d-bhola , beyond the scope of this task. We're using third party tools for the heavy lifting and that would require a second fork (we're already using a fork of go-junit-report). If we had more control over the source code I'd be happy to oblige but it's too much effort for too little reward.
Ok.👍
Needs rebase