Open displague opened 3 years ago
Assuming we create a apv_ts_install.sh script, would it be placed in: /terraform-metal-anthos-on-baremetal/templates/apv_ts_install.sh
Or now that we are using modules in: /terraform-metal-anthos-on-baremetal/modules/apv_ts/main.tf /terraform-metal-anthos-on-baremetal/modules/apv_ts/variables.tf /terraform-metal-anthos-on-baremetal/modules/apv_ts/README.md /terraform-metal-anthos-on-baremetal/modules/apv_ts/assets/apv_ts_install.sh
My guess it the modules way is the preferred method.
Modules would be preferable for optional components, even if we don't get immediate reuse out of them. This will ensure that we can use them as modules later.
The directories that you've outlined sound good.
I'm hoping to see this issue resolved as part of Anthos 1.7.0 verification. https://cloud.google.com/anthos/clusters/docs/on-prem/1.7/downloads#latest
We should bundle the Anthos ready testing tools:
The requirements for these tests include network diagrams and scripted test results.
A testing folder should be provisioned on the control plane node(s).
Files named
network-logical.pdf
andnetwork-physical.pdf
should be generated or included in this project and deposited in the testing folder.A testing script should be included in the testing folder (example):
A testing configuration should be included in the testing folder (this would replace testcfg.apv.yaml from the example script above). Terraform should be equipped to supply the values needed by the test configuration. Here's an example: https://gist.github.com/displague/6ec57e2e5c6bdf15af67a1c42a8bc022