equinix / terraform-equinix-metal-openstack

OpenStack Cloud on Equinix Metal
https://registry.terraform.io/modules/equinix/openstack/metal/latest
Apache License 2.0
13 stars 12 forks source link

missing ExternalNetwork.sh? #37

Open AgnosticDBA opened 4 years ago

AgnosticDBA commented 4 years ago

README.md says to add external floating IPs, on the controller run; sudo bash ExternalNetwork.sh

Where do we find ExternalNetwork.sh? It would appear to be missing.

displague commented 3 years ago

@jmarhee is this still used or is this provisioned through Terraform?

jmarhee commented 3 years ago

It looks like this script was removed in commit 1ef41042fe3e7b2ca9e4c5e4e4fcab0b52e23c98; I'll look into this. ExternalNetwork.tf seem(ed) to be the only place this is referenced (rather than templated anywhere else), but it looks like this behavior might have been configured elsewhere, based on the commit.

jmarhee commented 3 years ago

Looks to have been largely moved into Terraform (attachment to controller, bridge configured), but the Readme was not updated to reflect this-- change incoming on, both, documentation and how this should be implemented for the new behavior.