equinix / terraform-provider-equinix

Terraform Equinix provider
https://deploy.equinix.com/labs/terraform-provider-equinix/
MIT License
47 stars 45 forks source link

feat: add `data "equinix_fabric_cloud_routers"` data source to product suite #678

Closed thogarty closed 1 month ago

thogarty commented 1 month ago
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 51.30112% with 131 lines in your changes are missing coverage. Please review.

Project coverage is 53.69%. Comparing base (503d9e1) to head (a2f35ce). Report is 40 commits behind head on main.

Files Patch % Lines
equinix/resource_fabric_cloud_router.go 0.00% 129 Missing :warning:
equinix/data_source_fabric_cloud_router.go 98.09% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #678 +/- ## =========================================== + Coverage 37.91% 53.69% +15.77% =========================================== Files 120 149 +29 Lines 19476 21698 +2222 =========================================== + Hits 7384 11650 +4266 + Misses 11884 9605 -2279 - Partials 208 443 +235 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctreatma commented 1 month ago

The ship may have sailed on this one, but in the future when adding a new resource or data source, I encourage you to add it in a separate, dedicated package under internal/resources/fabric/ rather than adding more stuff to the equinix package. (If you do that, I would recommend continuing to use terraform-plugin-sdk/v2 and saving the migration to terraform-plugin-framework for later.) That will avoid adding new things that need to be refactored in the future.

thogarty commented 1 month ago

The ship may have sailed on this one, but in the future when adding a new resource or data source, I encourage you to add it in a separate, dedicated package under internal/resources/fabric/ rather than adding more stuff to the equinix package. (If you do that, I would recommend continuing to use terraform-plugin-sdk/v2 and saving the migration to terraform-plugin-framework for later.) That will avoid adding new things that need to be refactored in the future.

@ctreatma , I'm following up with a few more so I'll keep that in mind. 👍