search

equinix / terraform-provider-equinix

Terraform Equinix provider
https://deploy.equinix.com/labs/terraform-provider-equinix/
MIT License
47 stars 45 forks source link

fix: ignore HTTP errors based only on status #702

Closed ctreatma closed 3 months ago

ctreatma commented 3 months ago

The equinix_errors.IgnoreHttpResponseErrors function was introduced to support migration of Metal resources from packngo to equinix-sdk-go. However, the check functions that were passed in to it (such as equinix_errors.IsNotFound) only work correctly for errors from equinix-sdk-go if the error is first converted to an ErrorResponse by calling equinix_errors.FriendlyErrorForMetalGo(resp, err).

This updates equinix_errors.IgnoreHttpResponseErrors to only check the response status code.

ctreatma commented 3 months ago

Converting to draft because there is some convoluted usage of state waiters for deletions that only works if the waiter returns an error object that includes the HTTP response, and this change doesn't help with that problem.

ctreatma commented 3 months ago

Closing; I think ultimately the ErrorResponse type and the FriendlyError methods should go away, since they don't seem to add much, but that's a bigger question and the existing code seems to be working well enough for now.