equinix / terraform-provider-equinix

Terraform Equinix provider
https://deploy.equinix.com/labs/terraform-provider-equinix/
MIT License
47 stars 45 forks source link

feat: Update Network Edge BGP Acceptance Tests to use fabric resources(fabric connection and service profile) #710

Closed kpdhulipala closed 1 week ago

kpdhulipala commented 1 week ago

feat: Update Network Edge BGP Acceptance Tests to use fabric resources(fabric connection and service profile)

ctreatma commented 1 week ago

These tests don't run in CI at the moment, and I'm not exactly sure what's needed to run them locally. If you and your team are able to run these tests and they work with these updates, that is enough for now.

The CODEOWNERS configuration in this repo means that only a review from @equinix/governor-ne-network-edge-engineering can make this PR mergeable.

kpdhulipala commented 1 week ago

These tests don't run in CI at the moment, and I'm not exactly sure what's needed to run them locally. If you and your team are able to run these tests and they work with these updates, that is enough for now.

The CODEOWNERS configuration in this repo means that only a review from @equinix/governor-ne-network-edge-engineering can make this PR mergeable.

We need to refactor these tests as they are dependent on V3 resources- ecx l2 connection and equinix_ecx_l2_sellerprofile and with the changes mentioned in below MR, I'm able to run them with refactored code. https://github.com/equinix/terraform-provider-equinix/pull/683/files#diff-1a6d9356dadc63745ca8780c874574545fb9a579ea616a8b47d806b95f7a979f