search

equinix / terraform-provider-metal

DEPRECATED Equinix Metal standalone TF provider. Use the unified Equinix Terraform Provider.
https://registry.terraform.io/providers/equinix/equinix/latest/docs/guides/migration_guide_equinix_metal
Mozilla Public License 2.0
14 stars 11 forks source link

include device filter in hwReservationStateRefreshFunc #217

Closed ocobles closed 2 years ago

ocobles commented 2 years ago

This PR aims to fix https://github.com/equinix/terraform-provider-metal/issues/208 and is related to https://github.com/equinix/terraform-provider-metal/pull/211

As described in the issue, get function was taking a nil packngo.GetOptions and therefore returning a nil Device required to check it Device ID has changed.

https://github.com/equinix/terraform-provider-metal/blob/edc45fee397d331d03bdd3722b52641cd4354936/metal/helpers_device.go#L123

It has been replaced:

r, _, err := client.HardwareReservations.Get(reservationId, &packngo.GetOptions{Includes: []string{"device"}})

codecov-commenter commented 2 years ago

Codecov Report

Merging #217 (8e8f832) into main (8191e1a) will increase coverage by 0.99%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   74.50%   75.49%   +0.99%     
==========================================
  Files          48       48              
  Lines        6302     6302              
==========================================
+ Hits         4695     4758      +63     
+ Misses       1390     1320      -70     
- Partials      217      224       +7
Impacted Files Coverage Δ
metal/helpers_device.go 82.53% <33.33%> (ø)
metal/datasource_metal_ip_block_ranges.go 40.86% <0.00%> (-41.74%) :arrow_down:
metal/resource_metal_bgp_session.go 46.91% <0.00%> (-38.28%) :arrow_down:
metal/datasource_metal_device_bgp_neighbors.go 71.09% <0.00%> (-26.57%) :arrow_down:
metal/resource_metal_project.go 80.59% <0.00%> (+1.49%) :arrow_up:
metal/resource_metal_device_network_type.go 68.42% <0.00%> (+6.31%) :arrow_up:
metal/resource_metal_spot_market_request.go 59.00% <0.00%> (+6.51%) :arrow_up:
metal/resource_metal_device.go 68.48% <0.00%> (+14.45%) :arrow_up:
metal/errors.go 82.56% <0.00%> (+14.67%) :arrow_up:
metal/datasource_metal_device.go 89.00% <0.00%> (+25.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8191e1a...8e8f832. Read the comment docs.