search

equinixmetal-archive / csi-packet

Kubernetes CSI driver for Equnix Metal, formerly Packet
Apache License 2.0
25 stars 13 forks source link

Plugin name is using the wrong domain name notation #87

Closed displague closed 4 years ago

displague commented 4 years ago

Since version v1.0.0 of the CSI Spec, the plugin name should be "csi.packet.net", not "net.packet.csi', as it is today.

https://github.com/container-storage-interface/spec/releases/tag/v1.0.0

From https://github.com/container-storage-interface/spec/blob/master/spec.md:

// The name MUST follow domain name notation format // (https://tools.ietf.org/html/rfc1035#section-2.3.1). It SHOULD // include the plugin's host company name and the plugin name, // to minimize the possibility of collisions. It MUST be 63 // characters or less, beginning and ending with an alphanumeric // character ([a-z0-9A-Z]) with dashes (-), dots (.), and // alphanumerics between. This field is REQUIRED.

https://github.com/packethost/csi-packet/blob/bae92e12327f651c6fe0f6403b1c2def40915b3c/pkg/driver/driver.go#L11