equinor / alitra

MIT License
1 stars 12 forks source link

Define frame as a name instead of a class containing only name #48

Closed MortFred closed 2 years ago

MortFred commented 2 years ago

Describe the improvement you would like to see Isar now uses the Pose model from Alitra. In this Pose model, a Frame class instance is included in Pose, Position and Orientation. The Frame class only has a single parameter:

class Frame:
    name: str

When Isar and Flotilla communicates, this Frame class object must also be defined in Flotilla backend, but 3(!) times for every Pose object. If the frame (which is really the asset context) was only an assetCode string then this would not be needed.

Creating an issue so that I don't forget to ask @Christdej about it...

How will this change existing functionality? No functionality change, but would make the code a whole less verbose

How will this improvement affect the current Threat Model? N/A

MortFred commented 2 years ago

Update: fixed this for Flotilla backend by assigning Frame as an entity tied to a Pose only, and then mapping the pose:frame:name variable from Alitra to this entity. Still, should frame for both position and orientation still exitst in Alitra?

MortFred commented 2 years ago

Finished discussed, closing issue