equinor / cc-components

Components and apps for CC.
MIT License
4 stars 0 forks source link

šŸ›: Workorder MCCR tab: Checklists is missing #621

Open atlewee opened 1 year ago

atlewee commented 1 year ago

Description

Some workorders is missing MCCRs in projectportal. Could it be because the checklists are connected to dummy-tags?

Reproduce

Open Workorder app on OGP project Open workorder: 25588400 image

Expected behavior

Number of checklists should match ProCoSys

aman-riaz commented 1 year ago

The logic in CustomAPI_WorkOrderChecklists (the api used to show MCCRs) filters out all tags which are not lci tags. What Atle is saying seems to be the case. I suggest switching to using another view: Custom_WorkOrderChecklist (This one should have all of them) or ask FAM to change the logic in CustomAPI_WorkOrderChecklists.

CustomAPI views are owned and maintained by FAM. @Gustav-Eikaas

MagnusGjosund commented 1 year ago

@aman-riaz can you add projectSchema to Custom_WorkOrderChecklist view?

kjellhaaland commented 10 months ago

I have discussed this with Magnus, and need some more context from @Gustav-Eikaas on what was discussed with regards to adding projectSchema to the view.

Notes: The _CustomWorkOrderChecklist view is missing some key fields, that is currently included in _CustomAPIWorkOrderChecklists. This includes tagId, description, mccrType, mccrStatus, mcPkgId, commpkgId and mccrResponsible

See https://famapi.equinor.com/index.html for comparing the models.

One solution would be to add the missing fields to the Custom_WorkOrderChecklist

Gustav-Eikaas commented 10 months ago

@aman-riaz Is it possible for you to add the missing fields so we can switch to the other view and close this view?

aman-riaz commented 10 months ago

Custom_WorkOrderChecklist_v1 now ready in FAM-api with new fields.

I suggest when you fetch the data, set a filter if possible to "Custom_WorkOrderChecklist_v1 .FormularGroup = "MCCR". This way you can only fetch the subset of data necessary for this purpose.

mccrType = FormularType mccrStatus = ChecklistStatus mcPkgId = MechanicalCompletionPacakgeId commpkgId = CommissioningPackageId mccrResponsible = ChecklistResponsible Description = WorkOrderDescription TagId = TagId (for display use TagNo)

@kjellhaaland

kjellhaaland commented 9 months ago

@aman-riaz the new view is missing MechanicalCompletionPackageUrlId and CommissioningPackageUrlId in order to create links to ProCoSys.

Can these fields be added to the view Custom_WorkOrderChecklist_v1?

kjellhaaland commented 8 months ago

ProCoSys har kommet med en oppdatering med deep-links for oppslag pƄ dette. Kanskje det kan brukes: https://procosys.equinor.com/Redirect/Swcr/{globalId} https://procosys.equinor.com/Redirect/PunchListItem/{globalId} https://procosys.equinor.com/Redirect/Checklist/{globalId} https://procosys.equinor.com/Redirect/CallOff/{globalId} https://procosys.equinor.com/Redirect/Tag/{globalId} https://procosys.equinor.com/Redirect/Project/{globalId} https://procosys.equinor.com/Redirect/CommPkg/{globalId} https://procosys.equinor.com/Redirect/McPkg/{globalId} https://procosys.equinor.com/Redirect/CommPkg/{globalId} https://procosys.equinor.com/Redirect/WorkOrder/{globalId} https://procosys.equinor.com/Redirect/WorkOrder/{globalId}

kjellhaaland commented 7 months ago

This issue is on hold until https://github.com/equinor/fusion-data-gateway/issues/545 is ready

ken-mellem commented 3 months ago

@kjellhaaland