✨: Pipetest Circuit Diagram

equinor / cc-components

Components and apps for CC.

MIT License

4 stars 0 forks source link

✨: Pipetest Circuit Diagram #833

Open kjellhaaland opened 7 months ago

kjellhaaland commented 7 months ago

Expected outcome

Add support for pipetest to the Circuit Diagram. Currently the diagram only supports HT. Similar view as the JC Circuit Diagram.

The relation betweeen HT cables and Pipetest need to be added, as it is currently not part of the data returned from the API.

Business Value / Developer Experience

Enables the user to se pipetests related to HeatTrace.

Acceptance Criteria

[x] All Pipetests related to all HT cables are shown in the Circuit Diagram.
[ ] The currently selected Pipetest is highlighted in the diagram

kjellhaaland commented 7 months ago

The current API implementation (ElectricalConsumers), does not return pipetests as part of the "network tree". It uses the /portal/{facility}/ele-net-consumer?tagNo={tagNo} endpoint in STID to fetch the data.

How to get the Pipetest tags as part of the data returned from STID?

Some suggestions to solutions

Change the underlying view in the STID API, to include the pipetest tags in the response
Use the already implemented EnrichWithFamTagsAsync in the ElectricalConsumers API to enrich the data. This function gets tags from Custom_ElectricalConsumersMCCR. Can Pipetests in some way be included here?
Enrich the data from STID with data from FAM by using the Custom_PipetestV1 view, by querying for HT tags.

@atlewee any thoughts on this?

atlewee commented 7 months ago

@kjellhaaland Should be somehow picked up from this table in FAM: ( master mapping table between HT and PipeTest ) TagId is htCable id

kjellhaaland commented 7 months ago

The Circuit Diagram is partially implemented in the Pipetest app.

Data is still fetched from STID and not FAM. (Same as HT)
HT Cables relation between Pipetest and HT is missing in JCA.
The currently selected pipetest is not highlighted in the CircuitDiagram, as it is missing the relation with HT. (in the data from STID)

@ken-mellem and @atlewee, is the current implementation sufficient, or should we start implementing the solution mentioned by Atle?

@kjellhaaland Should be somehow picked up from this table in FAM: ( master mapping table between HT and PipeTest ) TagId is htCable id

ken-mellem commented 7 months ago

@kjellhaaland I guess this warrants a chat.