search

equinor / cc-components

Components and apps for CC.
MIT License
4 stars 0 forks source link

🐛: Handover: MC status showing OK on empty packages #936

Closed atlewee closed 1 month ago

atlewee commented 2 months ago

Description

Packages without checklists gets OK status, should be OS.

Reproduce

Open a package with no mc scope. It will show MC status as "OK" Image

Expected behavior

Expect MC status to be "OS" like in old Fusion version + ProCoSys: Image

EdwardBrunton commented 2 months ago

When getting the data from FAM the Custom_CommissioningPackageV3 model contains the wrong status

Gustav-Eikaas commented 2 months ago

@aman-riaz Is this something we calculate in the view?

aman-riaz commented 2 months ago

The condition in the view did not take in account commpkg with mc scope = null. A condition for this have now been added. Please verify when you recieve the changes on your end @EdwardBrunton

MagnusGjosund commented 1 month ago

I have checked a lot of handovers with mc status OK in PP. Can't fint any that has Outstanding in ProCoSys. Seems like the problem is fixed. I will close the issue