equinor / completor

Advanced multi-segmented well completion tool

https://equinor.github.io/completor/

GNU Lesser General Public License v3.0

0 stars 0 forks source link

chore: Class-structure #136

Closed Aleksander-Karlsson closed 1 month ago

Aleksander-Karlsson commented 1 month ago

Description

Include a description of the change done

Remove class WellSchedule in favor of a single dictionary.
- Move it's previously assigned methods to appropriate file read_schedule.
Rename msws to schedule_data.
Rename CreateWells class to Wells, now that there are only one class with well in its name.
Divide up some of the reading and processing of schedule file in main create loop.
Handling of Method and assigning type based on Segment length now happens once.

Why

The motivation for the change (if applicable) Reduce the technical depth and cognitive complexity of the code.

How

How the change is implemented (if it's not self evident in the diff)

Close: #XXX

Checklist:

Before submitting this PR, please make sure:

[x] I am complying with the contributing doc
[x] My code builds clean without any errors or warnings
[ ] I have added/extended tests that prove my fix is effective or that my feature works
[x] I have made corresponding changes to the documentation, and it builds correctly