Closed BeckyBrekke closed 2 years ago
Will wait for @lucasveil to return from vacay so we can discuss.
After meeting with @BeckyBrekke 08/09 I will fix the list and have Rebecca do a last review
The zeroheight fixes are good to go, will publish a new release soon so all the changes are pushed out.
All the checked issues are fixed ⬆️ I found still some small things around ⬇️
Popover
component. Wouldn’t be usefully we add link to Popover
code tab? 🤔
Agreed Demo is now implementedButtonGroup
placed and described under Button
component. Shall we add some additional, good practice description about ButtonGroup
? 🤔
Discussed in team with design/dev and agreed on a new issueTypography
component. Wouldn’t be usefully we add link to Typography
code tab? 🤔
Agreed. Added a new tab and link to code code
tab there is link only for CircularProgress
, lacking the rest.
Added linear, dots and star in the code taboverview
& code
tab need update. The SingleSelect
& MultiSelect
, are deprecated.
Now there is a relevant issue #2457 code
tab link is broken.Why some components has this nice display under Demo
like here ⬇️
while other looks like that ⬇️
@lucasveil When I published the changes, none of the links in the "More examples available in the code tab" worked. @ https://app.zenhub.com/workspaces/equinor-design-system-604f57c09e350a0011b654f4/issues/equinor/design-system/2156 You did most of them, but I did some too and was pretty sure I did it the correct way. Can we look at it next week?
@lucasveil When I published the changes, none of the links in the "More examples available in the code tab" worked. @
Some links works, the only ones that didn't work i listed above.
The issue was that zeroheight made a redirect to the links in the CMS. I have now fixed all the url and it should work on the next publish @BeckyBrekke @martalalik
Looks good, small changes: Fixed the link to storybook for the topbar. Made the windows taller for the progress indicators to remove scrollbars Bolded the period at the end of the sentence: "More examples available in the code tab." since the whole sentence was bold.
Copying this from #2156. Fixing the broken links in that issue but the rest should be looked at.
For zeroheight: