equinor / design-system

The Equinor design system
MIT License
119 stars 64 forks source link

Improvements for components in storefront #2332

Closed BeckyBrekke closed 2 years ago

BeckyBrekke commented 2 years ago

Copying this from #2156. Fixing the broken links in that issue but the rest should be looked at.

For zeroheight:

BeckyBrekke commented 2 years ago

Will wait for @lucasveil to return from vacay so we can discuss.

lucasveil commented 2 years ago

After meeting with @BeckyBrekke 08/09 I will fix the list and have Rebecca do a last review

BeckyBrekke commented 2 years ago

The zeroheight fixes are good to go, will publish a new release soon so all the changes are pushed out.

martalalik commented 2 years ago

All the checked issues are fixed ⬆️ I found still some small things around ⬇️

TODO:

Why some components has this nice display under Demo like here ⬇️ Screenshot 2022-08-26 at 13 54 25

while other looks like that ⬇️ Screenshot 2022-08-26 at 13 56 19

BeckyBrekke commented 2 years ago

@lucasveil When I published the changes, none of the links in the "More examples available in the code tab" worked. @ https://app.zenhub.com/workspaces/equinor-design-system-604f57c09e350a0011b654f4/issues/equinor/design-system/2156 You did most of them, but I did some too and was pretty sure I did it the correct way. Can we look at it next week?

martalalik commented 2 years ago

@lucasveil When I published the changes, none of the links in the "More examples available in the code tab" worked. @

Some links works, the only ones that didn't work i listed above.

lucasveil commented 2 years ago

The issue was that zeroheight made a redirect to the links in the CMS. I have now fixed all the url and it should work on the next publish @BeckyBrekke @martalalik

BeckyBrekke commented 2 years ago

Looks good, small changes: Fixed the link to storybook for the topbar. Made the windows taller for the progress indicators to remove scrollbars Bolded the period at the end of the sentence: "More examples available in the code tab." since the whole sentence was bold.