equinor / design-system

The Equinor design system
MIT License
118 stars 64 forks source link

Dialog eds 2.0 improvements #2750

Open oddvernes opened 1 year ago

oddvernes commented 1 year ago

Current dialog is locked at 242px wide. The content area height when scrollable prop is set is 104px bilde.png This is overly restrictive and useless in many use cases. I propose variants similar to sidesheet (small, medium, large + custom) where small is the current size. The sizes should use clamp to keep it responsive. We might want to change the scrollable to first automatically fill most of the viewport height before content starts scrolling instead of a fixed pixel value. (or make that default behaviour and deprecate scrollable prop)

Other inputs and discussion is welcome, this is just a starting point!

trylle commented 10 months ago

Adding my 2c to this one, ref https://equinor.slack.com/archives/CJT20H1B9/p1702545353898899: