Open oddvernes opened 1 year ago
Adding my 2c to this one, ref https://equinor.slack.com/archives/CJT20H1B9/p1702545353898899:
Dialog
should have some sensible min-width
and max-width
assigned by default instead of a fixed width
.Dialog.Actions
component requires a wrapper component with non-trivial styling, which does not appear to be documented in the storybook, and IMO should be handled internally by the library. At least one of the storybook examples does not include this wrapper and therefore looks wrong if you try it. Curiously enough, that particular example does not include a preview.place-self: stretch
. I do not have access to Figma anymore, so I can't compare with the original design.
Current dialog is locked at
242px
wide. The content area height when scrollable prop is set is104px
This is overly restrictive and useless in many use cases. I propose variants similar to sidesheet (small, medium, large + custom) where small is the current size. The sizes should useclamp
to keep it responsive. We might want to change thescrollable
to first automatically fill most of the viewport height before content starts scrolling instead of a fixed pixel value. (or make that default behaviour and deprecate scrollable prop)Other inputs and discussion is welcome, this is just a starting point!