equinor / design-system

The Equinor design system
MIT License
121 stars 64 forks source link

Make SideBar icon optional #2882

Open yusijs opened 1 year ago

yusijs commented 1 year ago

We want to use the SideBar to navigate a list of deliveries, where it would have a shortened text when collapsed. Collapsed: image Expanded: image

Describe the solution you'd like

I want the SideBar to require either an icon-prop or a shortLabel prop

Describe alternatives you've considered

I tried hacking a function to generate the svg path on the fly, but it started to feel overkill when I had to use opentypejs .. :D

Additional context

Add any other context or screenshots about the feature request here.

oddvernes commented 1 year ago

This should be doable! 👍

vnys commented 1 year ago

We’ll discuss it in the team, but we’re sceptical to how much value it would bring to have such little space for text labels.