equinor / design-system

The Equinor design system
MIT License
119 stars 64 forks source link

Rich tables are not properly drawn with Equinor monospace font #3095

Open trylle opened 1 year ago

trylle commented 1 year ago

Describe the bug

We use https://github.com/Textualize/rich to improve the terminal output of our Radix jobs. However, the Equinor monospace font does not appear to draw these correctly (incorrect spacing both horizontally and vertically).

image Radix log console output with EquinorMono font

image Radix log console output with Fira Code font

Steps to reproduce the bug

  1. Draw the following with the Equinor monospace font
    ╭────────────────┬────────────────────────────┬──────────────────┬────────────────────────────╮
    │ Current time   │ 2023-10-09 08:01:48.801789 │                  │                            │
    │ Last read time │ 2023-10-09 08:00:54.550400 │ Last write time  │ 2023-10-09 08:00:54.605959 │
    │ CPU usage      │ 1.3%                       │ Memory usage     │ 255 MB                     │
    │ Merge state    │ WAITING_FOR_PRIMARY        │                  │                            │
    │ Ingress time   │ 928s                       │ Input dataframes │ 12                         │
    │ App eval time  │ 0.373s                     │ Output rows      │ 12                         │
    │ Egress time    │ 15.7s                      │                  │                            │
    ╰────────────────┴────────────────────────────┴──────────────────┴────────────────────────────╯

Expected behavior

The table should be properly rendered with aligned/connected lines, such as in the Fira Code example.

Specifications

Additional context

Add any other context or screenshots about the bug. An example in CodeSandbox is very helpful

BirteThornquist commented 10 months ago

Sorry but we can't prioritise this issue right now.