equinor / dlisio

Python library for working with the well log formats Digital Log Interchange Standard (DLIS V1) and Log Information Standard (LIS79)
https://dlisio.readthedocs.io/en/latest/
Other
121 stars 39 forks source link

fixed urls in readme #428

Closed geolr closed 12 months ago

geolr commented 1 year ago

now, no dead links should be left

achaikou commented 1 year ago

Hi, thank you for your discoveries and contribution, but I think we need to fix more before this change could be merged.

Please also note that dlisio is not actively worked on for the moment and we are on limited capacity for efficient managing of the project. So if you'd like to fix those issues yourself it might take significant time from our side to respond.

geolr commented 1 year ago

True, the RP66 V1 is not really there either... Sent mail to energistics (you on CC).

Should I close this then, or do you want to keep the other links?

achaikou commented 1 year ago

Wow, thank you very much for doing this! :heart_eyes:

If you want to have it merged, I recommend you to do the following:

Have just one commit. Rename it to Fix broken links in Readme (we use this guideline)

This message implies that only some Readme links are fixed and allows us in the future to fix remaining dead links across the repo without forcing you to spend time on it now.

I will try to find time next week to investigate tests failures so we can have it merged rather sooner than later, but no promises. (Changes of course should have no impact on the code, but it is a bit weird to merge with failing CI...)

If you don't want to deal with it yourself, you can close the issue, and I will add you as a co-author whenever we get to fix it.