equinor / energyvision

Home of the equinor.com website
https://www.equinor.com
MIT License
33 stars 8 forks source link

As editors we would like to have an inpage component to help users navigate down long scroll pages to the relevant content. #2237

Open NickHaggerty1 opened 5 months ago

NickHaggerty1 commented 5 months ago

Component should be able to link to anchors that editors have placed. Component should automatically display based on number of inputs. Editor adds title (either for example A, B, C or project titles and relevant anchor link)

Screenshot 2024-04-15 at 14.49.32.png

Examples (yes I like clothes websites!): https://www.careofcarl.no/varemerker https://www.endclothing.com/row/brands

meols commented 3 months ago

I've tested a bit on this page, and have some comments: The setting up and jumping down works well. When adding eight navigation items there is a lot of space between the 7th and the 8th item on the second row (on desktop). Should we allow for more than 6 items in a row? Also a bit strange when it comes below the H1, of course depending on the chosen banner type. When I add a title to the component it looks like it needs more spacing (but I leave that to Nick and Borghild:smile:) For mobile the component takes up a lot of space - should we have a scroll for it?

image.png image.png image.png
BorghildSelle commented 3 months ago

@meols Good points, will work on those and reduce some spacing

BorghildSelle commented 1 month ago

@meols Acceptance criterias

meols commented 1 month ago

@BorghildSelle - I don't see a list of anchor links component...

BorghildSelle commented 1 month ago

Move code from branch inpage-links to inpage-links-v2 because long merge list

NickHaggerty1 commented 3 weeks ago

@BorghildSelle @meols Hey. Did a little testing with and think its working great. I say approved

meols commented 1 week ago

Agree - works great and approved :smile: