equinor / energyvision

Home of the equinor.com website
https://www.equinor.com
MIT License
33 stars 8 forks source link

Iframe adjustments #730

Closed meols closed 2 years ago

meols commented 2 years ago

Acceptance criteria

Note

The new options should only be applied for the Topic page template

meols commented 2 years ago

Due to layout requirements we would need to add a (optional) descriptive/caption text field under iframe, to provide a description of the content to appear below the video/iframe component We also need a (optional) call to action placed in iframe component to appear below the video/iframe component. See this page: https://energyvision.app.radix.equinor.com/careers/apprentices

wenche commented 2 years ago

@BirteThornquist I can add the fields in Sanity, but let's see how it should look like in the web tomorrow aka Envis day

wenche commented 2 years ago

Need to align with @BirteThornquist for this one.

wenche commented 2 years ago

We want to test the last alternative design in Figjam for this.

BirteThornquist commented 2 years ago

I added an ingress, a capture text and a CTA for the iFrame component, find the design here All the fields will be optional.Skjermbilde 2022-01-24 kl. 10.11.47.png

SvSven commented 2 years ago

Keep in mind that the iframe is used on the news article and event templates as well as the topic pages.

wenche commented 2 years ago

@BirteThornquist Let's fine tune the spacings tomorrow Skjermbilde 2022-01-26 kl. 14.54.27.png

BirteThornquist commented 2 years ago

@wenche LGTM! Please review @nicholas-haggerty @meols

nicholas-haggerty commented 2 years ago

@BirteThornquist looks good to me.