Closed wenche closed 2 years ago
Possible solution: figure out all places where isStatic is being used -> refactor to external links -> remove isStatic
(isStatic was intended for old AEM topic pages)
Below are the links which has text block with static links ( linking to archived news )
Pages with Promotiles having static links https://www.equinor.com/no/energi/elektrifisering-av-plattformer https://www.equinor.com/energy/electrification-of-platforms
@meols Above are the links to pages that have static links to archived pages. Do we need these links to archived pages?
@meols Please take a look at the comments above.
@meols @jorgol I checked the links again and all these pages have static links pointing to archived news.
Thanks. I'll review all the pages manually and correct/remove where needed. Not that many :)
@padms I've now gone through all of the listed pages and replaced the static links. Can you do another crawl to be sure? If there are no hits, I believe we're ready to remove the static links feature.
@jorgol Only this page is left ( which is missing in the above list ) https://www.equinor.com/investors/quarterly-results
Thanks, @padms. I've gone through this page and re-published now. As there were many links, could you re-check just to be sure?
@jorgol All the Q4 press release links are not updated. 5 of them
@padms You're right. Fixed. Please check again now.
Added feature flag in the query. Will clean up web after acceptance.
LGTM
@meols Option to add static urls is removed from call to actions in textblock, footer, menu, table and promotiles components. This can be tested in dev.
Great! Thanks @padms
During migration we added a switch for
isStatic
in the link selector component. The idea was to use this in combination with the url for some static content to be able to create a Next link (since it's internal content from the clients point of view). However, this feature is not much used, and could probably be removed from the code base as it adds some complexity both in the Sanity and in the web.TODO
EDIT: This is actually used for linking to some of the old news articles. Should we find a clever way to solve this issue in particular?