search

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
101 stars 104 forks source link

Move some observation data logic away from StorageInfoWidget #8085

Closed yngve-sk closed 2 months ago

yngve-sk commented 3 months ago

to local_experiment.py Issue Resolves https://github.com/equinor/ert/issues/8081

yngve-sk commented 3 months ago

Screenshot 2024-06-06 at 10 25 12

yngve-sk commented 3 months ago

Screenshot 2024-06-06 at 11 54 33

dafeda commented 3 months ago

I updated to the latest xarray: pip install xarray==2024.5.0, set the breakpoint on line 1334 in local_ensemble.py and ran test_that_posterior_has_lower_variance_than_prior() as you suggested.

to_dataframe() seems now to retain the order:

image

You mentioned that we for some reason can't use the latest version of xarray @larsevj . What is the reason for this?

larsevj commented 3 months ago

That was only for python3.8 where latest supported version is 2023.1.0, for python3.11 we can use the newest xarray, but we still have to support both of them.

larsevj commented 3 months ago

The newest xarray 2024.05 changed some of the ordering to be more consistent from what I could see. There is something weird that happens when you write to netcdf file and read it again, as I see you already have discussed above.

dafeda commented 3 months ago

That was only for python3.8 where latest supported version is 2023.1.0, for python3.11 we can use the newest xarray, but we still have to support both of them.

Thanks, I guess we just have to live with it.