equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
101 stars 104 forks source link

Let LSFDriver pick num_cpu from the realization object #8094

Closed berland closed 3 months ago

berland commented 3 months ago

Issue Resolves #8095

Approach Use the Realization object which is pre-populated with the correct cpu count.

When applicable

xjules commented 3 months ago

It makes sense. Just wondering about two things:

berland commented 3 months ago
  • Can it really change from realization to realization?

The previous driver would allow it if the ensemble builder built the realization in that way, but the ensemble builder will not do that currently. Even if the number of CPUs were parametrized in the Eclipse DATA deck (the num_cpu parser in the config will just not work in that case).

  • Why are we sending it explicitly for the OpenPBS driver?

I put it into the abstract driver, so it should support the same signature, but the LocalDriver and the OpenPBSDriver will currently ignore it. The OpenPBS driver should be refactored to use the same num_cpu as the LsfDriver, but that will be a kind of breaking change compared to the removed C Torque driver since that is using NUM_NODES and NUM_CPUS_PER_NODE.