Closed xjules closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.88%. Comparing base (
abb9957
) to head (b7044ad
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Squash the commits? The explanation under "Approach" should also be in the git commit message.
nitpick: First line in git commit message should be less than 50 chars, and the remaining lines should be formatted at 72 chars.
It might make sense to keep the publisher sentinel in place, to avoid rare corner cases where all events are "sent" but not yet added to the queue, and then it might exit prematurely.
Also, the commit message should be formatted to less than 50 chars on the first line, and then 72 chars for the body.
Issue Improves symptoms of https://github.com/equinor/ert/issues/8105
Approach We include scheduler._events.join() and SENTINEL object to make sure that the events left in the qeueu will be proccessed once the jobs are done. To makes sure we won't wait for the queue and SENTINEL indefinitely this introduces self._queue_timeout attribute.
When applicable