equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
101 stars 104 forks source link

Improve LSFDriver.kill and logging for scheduler #8112

Closed xjules closed 2 months ago

xjules commented 2 months ago

The goal of this backport is the improve flakyness of integration tests around LSFDriver.kill. Mainly, we fix a bug when the job is not running yet, but driver.kill wants to kill it.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.37%. Comparing base (dc1effb) to head (d3cb9a9).

Files Patch % Lines
src/ert/scheduler/scheduler.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## version-10.1 #8112 +/- ## ================================================ - Coverage 85.38% 85.37% -0.01% ================================================ Files 381 381 Lines 23651 23659 +8 Branches 893 874 -19 ================================================ + Hits 20195 20200 +5 + Misses 3349 3345 -4 - Partials 107 114 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xjules commented 2 months ago

Wrong order of commits, closing this PR.