equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
101 stars 105 forks source link

Variable naming: *_name or *_key? #8115

Open yngve-sk opened 3 months ago

yngve-sk commented 3 months ago

We should pick one and just stick to it. Potentially lock down one future use, but doing a rename of all variables might be a more smooth way to "enforce" this.

  1. (Not breaking) All variable names could be changed
  2. (Breaking) Configs
  3. (Breaking) Datasets
dafeda commented 3 months ago

I vote for key because it is used when joining.

yngve-sk commented 3 months ago

I just want it to be consistent, key is a bit more database like, so key sounds good to me