equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
99 stars 104 forks source link

Have partialsnapshot use typeddicts instead of dicts. #8122

Open jonathan-eq opened 1 month ago

jonathan-eq commented 1 month ago

Approach ✏️

(Screenshot of new behavior in GUI if applicable)

When applicable

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.20%. Comparing base (7440057) to head (fd221ba). Report is 5 commits behind head on main.

Files Patch % Lines
src/ert/ensemble_evaluator/snapshot.py 98.14% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8122 +/- ## ========================================== + Coverage 86.08% 86.20% +0.12% ========================================== Files 383 383 Lines 23744 23784 +40 Branches 630 635 +5 ========================================== + Hits 20440 20504 +64 + Misses 3229 3207 -22 + Partials 75 73 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonathan-eq commented 1 month ago

Will this PR be superseded by https://github.com/equinor/ert/pull/8182? @JHolba