equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
99 stars 104 forks source link

Refactor RunDialog and remove indeterminate flag #8130

Closed andreas-el closed 1 month ago

andreas-el commented 1 month ago

The concept of indeterminate was probably to switch between the waiting-for-updates-progress-bar, and showing the actual progress bar when there was a proper state. The current implementation never switches back after the first update, so we decided to remove it for now. Retained current behaviour.

Issue Resolves #my_issue

Approach Short description of the approach

(Screenshot of new behavior in GUI if applicable)

When applicable

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.59%. Comparing base (193ff03) to head (9aa4d27). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8130 +/- ## ========================================== + Coverage 86.51% 86.59% +0.07% ========================================== Files 383 383 Lines 23742 23783 +41 Branches 625 627 +2 ========================================== + Hits 20541 20594 +53 + Misses 3122 3111 -11 + Partials 79 78 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.