Validate number of arguments for workflows

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

101 stars 105 forks source link

Validate number of arguments for workflows #8133

Closed oyvindeide closed 3 months ago

oyvindeide commented 3 months ago

Closes: https://github.com/equinor/ert/issues/6699

There was no validation for workflows, and misconfiguration could cause ert to hang.

[x] PR title captures the intent of the changes, and is fitting for release notes.
[x] Added appropriate release note label
[x] Commit history is consistent and clean, in line with the contribution guidelines.
[x] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[ ] Large PR: Prepare changes in small commits for more convenient review
[ ] Bug fix: Add regression test for the bug
[ ] Bug fix: Create Backport PR to latest release

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.53%. Comparing base (37c4d20) to head (b1e5422). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8133 +/- ## ========================================== + Coverage 86.51% 86.53% +0.02% ========================================== Files 383 383 Lines 23742 23749 +7 Branches 629 627 -2 ========================================== + Hits 20540 20552 +12 + Misses 3126 3122 -4 + Partials 76 75 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.