Fix test_unexpected_close

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

99 stars 104 forks source link

Fix test_unexpected_close #8136

Open JHolba opened 1 month ago

JHolba commented 1 month ago

The test failed on macos due to missing exception.

Closes #8124

Approach Wait for socket to be closed before signaling done from monitor

[ ] PR title captures the intent of the changes, and is fitting for release notes.
[x] Added appropriate release note label
[x] Commit history is consistent and clean, in line with the contribution guidelines.
[x] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[ ] Large PR: Prepare changes in small commits for more convenient review
[ ] Bug fix: Add regression test for the bug
[ ] Bug fix: Create Backport PR to latest release

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.00%. Comparing base (8b1a379) to head (3129367). Report is 157 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8136 +/- ## ========================================== + Coverage 86.51% 87.00% +0.48% ========================================== Files 383 376 -7 Lines 23749 23576 -173 Branches 618 629 +11 ========================================== - Hits 20547 20512 -35 + Misses 3121 2984 -137 + Partials 81 80 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JHolba commented 1 week ago

As mentioned by @berland inject a few lines of explanation in the commit message. Otherwise it is 🎉

added a bit more explanation to commit message.