Simplify simulation arguments to run models

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

101 stars 105 forks source link

Simplify simulation arguments to run models #8140

Closed oyvindeide closed 3 months ago

oyvindeide commented 3 months ago

The intention here is to reduce the statefullness of the run models, by reducing the use of simulation arguments as holders of state, and internalizing state on the run models instead. Also to simplify the simulation arguments by removing a lot of unneeded properties.

This results in a breaking change for the cli, which aligns it with the GUI in terms of naming the ensembles in ensemble smoother.

Closes #7633

[x] PR title captures the intent of the changes, and is fitting for release notes.
[x] Added appropriate release note label
[x] Commit history is consistent and clean, in line with the contribution guidelines.
[x] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[x] Large PR: Prepare changes in small commits for more convenient review
[x] Bug fix: Add regression test for the bug
[x] Bug fix: Create Backport PR to latest release

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.56%. Comparing base (f29176b) to head (e238e0d).

Files	Patch %	Lines
src/ert/run_models/multiple_data_assimilation.py	81.25%	3 Missing :warning:
src/ert/cli/main.py	0.00%	1 Missing :warning:
src/ert/storage/local_storage.py	66.66%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8140 +/- ## ========================================== - Coverage 86.62% 86.56% -0.06% ========================================== Files 384 384 Lines 23831 23773 -58 Branches 618 627 +9 ========================================== - Hits 20644 20580 -64 - Misses 3107 3112 +5 - Partials 80 81 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oyvindeide commented 3 months ago

Semeio failure is expected, fix here: https://github.com/equinor/semeio/pull/624