Remove RMS forward model

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

99 stars 104 forks source link

Remove RMS forward model #8141

Closed larsevj closed 1 month ago

larsevj commented 1 month ago

Issue Resolves #7859

Approach Short description of the approach

(Screenshot of new behavior in GUI if applicable)

[x] PR title captures the intent of the changes, and is fitting for release notes.
[ ] Added appropriate release note label
[x] Commit history is consistent and clean, in line with the contribution guidelines.
[x] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[ ] Large PR: Prepare changes in small commits for more convenient review
[ ] Bug fix: Add regression test for the bug
[ ] Bug fix: Create Backport PR to latest release

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.58%. Comparing base (c1d2e21) to head (ee93a4a). Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8141 +/- ## ========================================== + Coverage 86.57% 86.58% +0.01% ========================================== Files 383 383 Lines 23830 23802 -28 Branches 636 629 -7 ========================================== - Hits 20630 20610 -20 + Misses 3127 3118 -9 - Partials 73 74 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

larsevj commented 1 month ago

I assume this one will also be handled by rms-sys: get_rms_config_path()

mferrera commented 1 month ago

I assume this one will also be handled by rms-sys: get_rms_config_path()

Yep, in a way. It has the configuration already embedded in the same package