equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
99 stars 104 forks source link

Fix signature of overrides from QAbstractItemModel #8147

Closed eivindjahren closed 1 month ago

eivindjahren commented 1 month ago

To satisfy LSP it should have exactly the same signature as QAbstractItemModel.

When applicable

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.69421% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.59%. Comparing base (b844a05) to head (e69f709). Report is 2 commits behind head on main.

Files Patch % Lines
src/ert/gui/ertwidgets/models/storage_model.py 90.00% 2 Missing :warning:
src/ert/gui/model/progress_proxy.py 96.15% 1 Missing :warning:
src/ert/gui/model/real_list.py 96.55% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8147 +/- ## ========================================== - Coverage 86.60% 86.59% -0.01% ========================================== Files 383 383 Lines 23778 23813 +35 Branches 628 622 -6 ========================================== + Hits 20593 20622 +29 - Misses 3109 3115 +6 Partials 76 76 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.