Only get reals and forward models once from partial update

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

99 stars 104 forks source link

Only get reals and forward models once from partial update #8149

Closed JHolba closed 1 month ago

JHolba commented 1 month ago

Issue add_partial_snapshot in SnapshotModel is slow...

Approach Remove superfluous calls to PartialSnapshot

[ ] PR title captures the intent of the changes, and is fitting for release notes.
[x] Added appropriate release note label
[x] Commit history is consistent and clean, in line with the contribution guidelines.
[x] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[ ] Large PR: Prepare changes in small commits for more convenient review
[ ] Bug fix: Add regression test for the bug
[ ] Bug fix: Create Backport PR to latest release

JHolba commented 1 month ago

Tested this on a bigpoly that fails halfway through the realization. runtime went from 3m30s to 1m15s with this fix.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.60%. Comparing base (c24268b) to head (a630793).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8149 +/- ## =========================================== + Coverage 69.10% 86.60% +17.49% =========================================== Files 384 384 Lines 23826 23830 +4 Branches 636 635 -1 =========================================== + Hits 16466 20639 +4173 + Misses 7287 3118 -4169 Partials 73 73 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.