equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
99 stars 104 forks source link

Replacing progress view with progress widget #8152

Closed andreas-el closed 1 month ago

andreas-el commented 1 month ago

Replace LegendView and ProgressView with a simple ProgressWidget.

Visually the end result should be the same, but the complexity underneath should be greatly simplified. Now base_run_model will calculate the necessary numbers once, and the widget will use these for drawing the components.

If anything, the new code seems crisper in the text, and also does not shave off the very left side of the green finished label marker.

New

Screenshot 2024-06-14 at 11 27 58

Old

Screenshot 2024-06-14 at 11 30 51

When applicable

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.53%. Comparing base (77fa511) to head (2ec8244). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8152 +/- ## ========================================== + Coverage 76.93% 86.53% +9.60% ========================================== Files 383 382 -1 Lines 23813 23749 -64 Branches 625 628 +3 ========================================== + Hits 18320 20552 +2232 + Misses 5412 3124 -2288 + Partials 81 73 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.