equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
99 stars 104 forks source link

Bugfix: unswap key_index and obs_name #8155

Closed yngve-sk closed 1 month ago

yngve-sk commented 1 month ago

fixes oopsie. This effectively swapped the obs_name and key_index columns, which again set the ordering of the observations to be by key_index->obs_name when it really should be obs_name->key_index. It does not make the update step invalid, but it does alter the snapshots.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.60%. Comparing base (2b21402) to head (221e3cf). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8155 +/- ## ========================================== + Coverage 86.59% 86.60% +0.01% ========================================== Files 383 384 +1 Lines 23772 23831 +59 Branches 628 636 +8 ========================================== + Hits 20586 20640 +54 - Misses 3111 3118 +7 + Partials 75 73 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.