Use pandas for getting obs and responses

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

99 stars 104 forks source link

Use pandas for getting obs and responses #8156

Closed dafeda closed 1 month ago

dafeda commented 1 month ago

Mainly for readability

[ ] PR title captures the intent of the changes, and is fitting for release notes.
[ ] Added appropriate release note label
[ ] Commit history is consistent and clean, in line with the contribution guidelines.
[ ] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[ ] Large PR: Prepare changes in small commits for more convenient review
[ ] Bug fix: Add regression test for the bug
[ ] Bug fix: Create Backport PR to latest release

yngve-sk commented 1 month ago

Overall looks good

Need to update some snapshots and see if the changes look reasonable;

pytest --snapshot-update tests/unit_tests/all/plugins/test_export_misfit.py
pytest --snapshot-update tests/unit_tests/data/test_integration_data.py
pytest --snapshot-update tests/unit_tests/test_libres_facade.py

Manually check/update the values @

tests/unit_tests/scenarios/test_summary_response.py::test_that_mismatched_responses_gives_nan_measured_data

and also need to update test_that_get_measured_data_is_always_ordered logic to check sorting of the pandas dataframe