equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
99 stars 104 forks source link

Enable ruff preview checks #8158

Closed berland closed 1 month ago

berland commented 1 month ago

This extends the number of checks to pass for the ruff linter considerably, by including rules that are currently only marked for preview in ruff. These rules are in preview due to the automatic fix not being ready, but it does not mean that the rule is not valid.

All existing issues found by enabling this are currently marked as exceptions, to be solved one by one. At least, enabling this at least ensure that no new issues can be introduced unknowingly into the code base

Issue Resolves #7377

Approach

When applicable

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.61%. Comparing base (f29176b) to head (06252ba).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8158 +/- ## ========================================== - Coverage 86.62% 86.61% -0.02% ========================================== Files 384 384 Lines 23831 23831 Branches 618 630 +12 ========================================== - Hits 20644 20641 -3 - Misses 3107 3109 +2 - Partials 80 81 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.